This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
117: interactive clean up #389
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinbruce
force-pushed
the
117/interactive-tidy
branch
from
e557c89
to
0e4b0f1
Compare
Open
It allows us to compare json responses without having to match the exact key sequences
This will be used to implement the interactive tidy flow It displays a standard slack message to the user with each potential deletion candidate with a button prompt
This will be used to implement the interactive tidy flow It displays a modal (popup) slack message to the user describing the selected instance, to confirm, and requests the user's OTP passcode from their application
Add methods (and test) for opening and updating modals NOTE: Update is not used yet
Mirror the other helm functions and implement the context for delete
This validates that the OTP code provided by a user is vali This duplicates some code it currently handled in-line in the helm command, that will ultimately be removed
Ensure all posts to the slack auth.test endpoints return success
colinbruce
force-pushed
the
117/interactive-tidy
branch
from
597d6c4
to
c55265a
Compare
colinbruce
force-pushed
the
117/interactive-tidy
branch
from
c55265a
to
e7f38b9
Compare
Add handling and tests for updated Helm::Tidy function
Add handlers for new interactive responses, delete_branch and otp_response The interactive handlers have been extracted to inline classes, these may be extracted to /lib in the future but for now this reduces the complexity and size of the app class
colinbruce
force-pushed
the
117/interactive-tidy
branch
from
e7f38b9
to
74d1470
Compare
colinbruce
force-pushed
the
117/interactive-tidy
branch
from
74d1470
to
137068e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a user to select which instance to delete from a given context, prompt for their OTP and then delete when OTP matches