(Hopefully) Fix Cypress build failure #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `getTable` package has caused our build to fail as it's trying to install multiple versions of Cypress, so we're adding the implementation to our codebase instead. This implementation has been shamelessly copied from https://github.com/roggerfe/cypress-get-table/blob/master/src/index.js.
When running the build, we were getting a "Corrupted Download" message when trying to install Cypress. I believe this is due to the `get-table` package requiring an older version of Cypress as one of its dependencies. Here's how I came to that conclusion: cypress-io/cypress#4595
tomsmyers
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Removes the "get table" package to hopefully fix the build on CI, replacing it with a local copy of the implementation as a Cypress command.
What is the intent behind these changes?
When running the build, we were getting a "Corrupted Download" message when trying to install Cypress. I believe this is due to the
get-tablepackage requiring an older version of Cypress as one of its dependencies, as well as trying to install our own version of Cypress for running our own end to end tests.Here's the issue that led me to that conclusion: cypress-io/cypress#4595