DCS-1435 Update dependencies #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrlee
commented
Feb 2, 2022
| "typescript": "^4.5.2" | ||
| "supertest": "^6.2.2", | ||
| "ts-jest": "^27.1.3", | ||
| "typescript": "^4.5.5" |
There was a problem hiding this comment.
there's some known issues with:
- redis
- MOJ frontend
- Govuk frontend
- axios
We'll need to create a new ticket for dealing with these
andrewrlee
commented
Feb 2, 2022
| "jsonwebtoken": "^8.5.1", | ||
| "jwt-decode": "^3.1.2", | ||
| "moment": "^2.29.1", | ||
| "moment-business-days": "^1.2.0", | ||
| "nocache": "^3.0.1", | ||
| "nock": "^13.2.1", |
There was a problem hiding this comment.
nock shouldnt be a dev dependency
andrewrlee
force-pushed
the
alee/DCS-1435
branch
from
37470ba
to
1c3b7f5
Compare
andrewrlee
commented
Feb 2, 2022
| @@ -1,5 +1,5 @@ | |||
| import { Moment } from 'moment' | |||
| import parse from 'csv-parse' | |||
| import { parse } from 'csv-parse' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.