Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP-1038 rename FlightDetails -> ExtraditionFlight #2246

Merged
merged 11 commits into from
May 13, 2024
Merged

Conversation

danbenton-mojdt
Copy link
Contributor

Rename FlightDetails to ExtraditionFlight as the plural-like name for a single object causes issues when (de)serialising in the front end

@danbenton-mojdt danbenton-mojdt requested a review from a team as a code owner May 13, 2024 10:56
@@ -3,9 +3,9 @@
require 'rails_helper'

RSpec.describe Api::FlightDetailsController do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RSpec.describe Api::FlightDetailsController do
RSpec.describe Api::ExtraditionFlightController do

@Thource Thource changed the title MAP-1038 rename FlightDetails -> ExtradtionFlight MAP-1038 rename FlightDetails -> ExtraditionFlight May 13, 2024
Copy link
Contributor

@Thource Thource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbenton-mojdt danbenton-mojdt merged commit 92db67c into main May 13, 2024
8 checks passed
@danbenton-mojdt danbenton-mojdt deleted the MAP-1038 branch May 13, 2024 15:26
Copy link

sentry-io bot commented May 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **NoMethodError: undefined method merge!' for nil:NilClass (NoMethodError)** Api::ExtraditionFlightController#create` View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants