Nomis alert comment (#2248)

* MAP-1038 rename FlightDetails -> ExtradtionFlight

* MAP-1038 Fix db migration

* Update spec/requests/api/extradition_flight_controller_update_spec.rb

Co-authored-by: Adam Sharp <adam.sharp@digital.justice.gov.uk>

* Update app/controllers/api/extradition_flight_controller.rb

Co-authored-by: Adam Sharp <adam.sharp@digital.justice.gov.uk>

* MAP-1038 Fix missed renames

* MAP-1038 Linting

* MAP-1038 Typos

* MAP-1038 revert create! -> new and save

* MAP-1038 datetime -> string column type

* MAP-1038 Fix table name in spec

* MAP-1038 Simplify extraditionFlight create

* comment -> comments

* Update test expectation

---------

Co-authored-by: Adam Sharp <adam.sharp@digital.justice.gov.uk>

app/lib/nomis_client/alerts.rb

@@ -23,7 +23,7 @@ def attributes_for(alert)
           alert_type_description: alert['alertTypeDescription'],
           alert_code: alert['alertCode'],
           alert_code_description: alert['alertCodeDescription'],
-          comment: alert['comment'],
+          comments: alert['comment'],
           created_at: alert['dateCreated'],
           expires_at: alert['dateExpires'],
           expired: alert['expired'],

spec/lib/nomis_client/alerts_spec.rb

@@ -14,7 +14,7 @@
           alert_type_description: 'Security',
           alert_code: 'XVL',
           alert_code_description: 'Violent',
-          comment: 'SIR GP162/11 17/01/11 - threatening to take staff hostage',
+          comments: 'SIR GP162/11 17/01/11 - threatening to take staff hostage',
           created_at: '2013-03-29',
           expires_at: '2018-06-08',
           expired: true,
@@ -27,7 +27,7 @@
           alert_type_description: 'Security',
           alert_code: 'XB',
           alert_code_description: 'Bully',
-          comment: 'PLACED ON ZT2 MONITORING FOR THREATS TO ASSAULT HIS ASSAILANTS.',
+          comments: 'PLACED ON ZT2 MONITORING FOR THREATS TO ASSAULT HIS ASSAILANTS.',
           created_at: '2015-11-21',
           expires_at: '2019-01-07',
           expired: false,