Fix soft linebreaks in editable content #2147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng whitespace that gets added by showdown too.
…space in the replace regex
chrispymm
force-pushed
the
testable-fix-soft-linebreaks-in-editable-content
branch
from
b7badf6
to
bbac905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When initialised,
<br>tags in the content html aren't being properly converted into\nfor a markdown soft linebreak.After much investigation, the issue here is showdown 🙄 The latest release version does not include a subParser a that handles
<br>elements. Yes, that's right, a very popular markdown conversion library cannot handle<br>tags.The code to handle br tags does exist within the showdown repo, it is just in the develop and master branches, (albeit still with a slight issue) I've posted a long comment to the showdown issue related to this and we'll see if I get a response, it doesn't seem like there's too much active development.
Solution:
Anyway, the solution for us right now is a regex to find and replace the rogue
<br>tags with the correct markdown syntax.Have also added a test to check for soft linebreak handling too.