Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lga 3075 ga4 new #1263

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Lga 3075 ga4 new #1263

wants to merge 8 commits into from

Conversation

digitalali-moj
Copy link
Contributor

@digitalali-moj digitalali-moj commented May 9, 2024

What does this pull request do?

Remove old GA3 code
Add basic GA4 code
Generate unique anonymous id and store in session
Pass ID onto backend

Public: #1263
Frontend: ministryofjustice/cla_frontend#956
Backend: ministryofjustice/cla_backend#1178

Any other changes that would benefit highlighting?

Adds anonymous user id to share with other services to be able to track UX end-to-end. This will just be for the session, but later for CLA backend will have to be stored in database when a case is created, linked to the case, so it can be retrieved in CLA Frontend and any other apps further down the line.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

Staging: https://lga-3075-ga4-new.staging.checklegalaid.service.gov.uk/

@digitalali-moj digitalali-moj force-pushed the LGA-3075-ga4-new branch 2 times, most recently from 501c934 to 4c04ea8 Compare May 13, 2024 11:25
@digitalali-moj digitalali-moj force-pushed the LGA-3075-ga4-new branch 2 times, most recently from 673a9fd to 43da4e7 Compare May 13, 2024 14:15
BenMillar-CGI
BenMillar-CGI previously approved these changes May 14, 2024
Copy link
Contributor

@BenMillar-CGI BenMillar-CGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the walkthrough 👍

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants