-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lga 3075 ga4 new #1263
Open
digitalali-moj
wants to merge
8
commits into
master
Choose a base branch
from
LGA-3075-ga4-new
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lga 3075 ga4 new #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalali-moj
force-pushed
the
LGA-3075-ga4-new
branch
from
May 13, 2024 09:53
79efa50
to
721e00c
Compare
digitalali-moj
force-pushed
the
LGA-3075-ga4-new
branch
2 times, most recently
from
May 13, 2024 11:25
501c934
to
4c04ea8
Compare
digitalali-moj
force-pushed
the
LGA-3075-ga4-new
branch
2 times, most recently
from
May 13, 2024 14:15
673a9fd
to
43da4e7
Compare
digitalali-moj
force-pushed
the
LGA-3075-ga4-new
branch
from
May 13, 2024 14:17
43da4e7
to
dfca2fc
Compare
BenMillar-CGI
previously approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for the walkthrough 👍
This was referenced May 28, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Remove old GA3 code
Add basic GA4 code
Generate unique anonymous id and store in session
Pass ID onto backend
Public: #1263
Frontend: ministryofjustice/cla_frontend#956
Backend: ministryofjustice/cla_backend#1178
Any other changes that would benefit highlighting?
Adds anonymous user id to share with other services to be able to track UX end-to-end. This will just be for the session, but later for CLA backend will have to be stored in database when a case is created, linked to the case, so it can be retrieved in CLA Frontend and any other apps further down the line.
Checklist
Staging: https://lga-3075-ga4-new.staging.checklegalaid.service.gov.uk/