LGA-2991 - Disable indexing and whitelisting of Non-Production environments #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
said-moj
force-pushed
the
feature/LGA-2991-hide-non-prod
branch
from
2cc1acf
to
0ec2806
Compare
said-moj
force-pushed
the
feature/LGA-2991-hide-non-prod
branch
from
0ec2806
to
b2a83e1
Compare
Pheonnexx
previously approved these changes
May 9, 2024
said-moj
force-pushed
the
feature/LGA-2991-hide-non-prod
branch
2 times, most recently
from
f8dafaf
to
3202696
Compare
said-moj
force-pushed
the
feature/LGA-2991-hide-non-prod
branch
from
739fb6b
to
1bb5881
Compare
|
said-moj
changed the title
digitalali-moj
approved these changes
May 10, 2024
| @@ -17,5 +17,6 @@ helm upgrade $CLEANED_BRANCH_NAME \ | |||
| --set image.repository=$DOCKER_REPOSITORY \ | |||
| --set image.tag=$IMAGE_TAG \ | |||
| --set dashboard.enabled=false \ | |||
| --set-string pingdomIPs=$PINGDOM_IPS \ | |||
There was a problem hiding this comment.
Is this dynamic staging. If so do we need pingdom access? Is it simpler to keep?
There was a problem hiding this comment.
yes this dynamic staging and no we don't need pingdom access on this environment. However it makes writing the config writing simpler
Pheonnexx
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Disable indexing and whitelisting of Non-Production environments
Any other changes that would benefit highlighting?
Pingdom IP addresses also needed to be added to the whitelist. However these frequently change, so an additional script is added to discover these IP addresses.
Checklist