Add hostNetwork config to Tenant spec #1942
Conversation
|
Please add minio-port and console-port. |
When using host networking. It may be desirable to adjust the MinIO and console ports to avoid port conflicts on the host. The services still expose MinIO and the console on the same ports as before.
|
@jiuker I have pushed a commit that makes the minio and console container ports configurable. This helps avoid port conflicts on the host when using host networking. The services will still expose MinIO and the console on the default ports, same as they did before. |
Sets the defaults for these ports and also a check in the Helm chart to make sure they cannot be set to the same value.
|
@mctoohey please help us to resolve conflicts |
There was a problem hiding this comment.
LGTM, but having an integration-test here would also be good. We're supporting some edge-case scenarios that we don't actually provide an integration test for. Adding integration tests would help keeping this stable or we should mark some items as "community" provided features that has different kind of stability compared to our standard deployment. We also lack support in the console for these edge-cases.
Allows
hostNetwork: trueto be configured on the tenant pods (https://kubernetes.io/docs/concepts/services-networking/network-policies/#networkpolicy-and-hostnetwork-pods).This can be desirable if you want to bypass the Kubernetes network layer and access MinIO more directly.