avoid sending a Ping() on a closed context #19731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
look-for-context
branch
from
ec81835
to
21d8218
Compare
klauspost
requested changes
May 14, 2024
| @@ -347,8 +347,14 @@ func (m *muxClient) handleOneWayStream(respHandler chan<- Response, respServer < | |||
| m.addErrorNonBlockingClose(respHandler, ErrDisconnected) | |||
| return | |||
| } | |||
| // Send new ping. | |||
| gridLogIf(m.ctx, m.send(message{Op: OpPing, MuxID: m.MuxID})) | |||
| select { | |||
There was a problem hiding this comment.
You are not removing the issue, just making it a tiny bit less likely. I will send a PR.
(the mux can still be closed between checking the context and sending the message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
avoid sending a Ping() on a closed context
Motivation and Context
It just avoids some extra logs
How to test this PR?
Disconnecting nodes might log some unexpected things
Types of changes
Checklist:
commit-idorPR #here)