Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DelMarkerExpiration to DeletedObjectExpiration #19666

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krisis
Copy link
Member

@krisis krisis commented May 3, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Rename the recently introduced ILM action DelMarkerExpiration to DeletedObjectExpiration. This action is not yet usable without the necessary client-side support like mc for e.g.

Motivation and Context

DeletedObjectExpiration captures two important consequences of this ILM action better.

  1. It applies on a deleted object, i.e an object with DEL marker as its current (latest) version.
  2. It removes the entire object, i.e all current and noncurrent versions of a qualifying deleted object.

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana
Copy link
Member

Is this ready? @krisis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants