Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ILM metrics in metrics-v3 #19539

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ILM metrics in metrics-v3 #19539

wants to merge 2 commits into from

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Apr 18, 2024 •
edited

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Endpoint: /minio/metrics/v3/ilm
Metrics:

  • expiry_pending_tasks
  • transition_active_tasks
  • transition_missed_immediate_tasks
  • transition_pending_tasks
  • versions_scanned

Motivation and Context

https://github.com/miniohq/engineering/issues/1510

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@balamurugana balamurugana marked this pull request as draft April 18, 2024 03:12
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch from 8772cb3 to 5569cda Compare April 19, 2024 02:01
@balamurugana balamurugana marked this pull request as ready for review April 19, 2024 02:02
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch from 5569cda to 511eb44 Compare April 26, 2024 04:05
anjalshireesh
anjalshireesh requested changes May 6, 2024
View reviewed changes
docs/metrics/v3.md Outdated Show resolved Hide resolved
cmd/metrics-v3-cluster-ilm.go Outdated Show resolved Hide resolved
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch from 511eb44 to d8ef595 Compare May 7, 2024 03:10
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch 2 times, most recently from 1624665 to b5affab Compare May 23, 2024 09:00
anjalshireesh
anjalshireesh requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per latest discussions, the ilm metrics should be per-server (not cluster level), and should be moved from /cluster/ilm to root level i.e. /ilm cc @kannappanr

cmd/metrics-v3-cluster-ilm.go Outdated Show resolved Hide resolved
@balamurugana balamurugana changed the title Add cluster ILM metrics in metrics-v3 Add ILM metrics in metrics-v3 May 23, 2024
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch 2 times, most recently from 9aeb390 to 2f31cfc Compare May 23, 2024 17:40
anjalshireesh
anjalshireesh requested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, couple of small comments in the documentation.

docs/metrics/v3.md Show resolved Hide resolved
docs/metrics/v3.md Outdated Show resolved Hide resolved
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch 2 times, most recently from 31542d2 to c6e09df Compare May 24, 2024 15:12
@balamurugana @anjalshireesh
Add ILM metrics in metrics-v3
8273d9a 
Co-authored-by: Shireesh Anjal <355479+anjalshireesh@users.noreply.github.com>
Signed-off-by: Bala.FA <bala@minio.io>
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch from c6e09df to 8273d9a Compare May 27, 2024 15:02
anjalshireesh
anjalshireesh approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravindk89 ravindk89 ravindk89 left review comments

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

@krisis krisis Awaiting requested review from krisis

@kannappanr kannappanr Awaiting requested review from kannappanr

Assignees

@balamurugana balamurugana

Labels
needs-review new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@balamurugana @anjalshireesh @harshavardhana @ravindk89 @bh4t