Fix s3zip not returning data #13442
Merged
Fix s3zip not returning data #13442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not reliably know the length of compressed data, including headers. Request until the end-of-stream. Results will still be properly truncated. Fixes minio#13441
Mint Automation
|
klauspost
added a commit
to klauspost/minio-go
that referenced
this pull request
Oct 14, 2021
Requires minio/minio#13442 to pass.
harshavardhana
approved these changes
Oct 14, 2021
rluetzner
pushed a commit
to iternity-dotcom/minio
that referenced
this pull request
Jun 8, 2022
We do not reliably know the length of compressed data, including headers. Request until the end-of-stream. Results will still be properly truncated. Fixes minio#13441 (cherry picked from commit 76239fa)
rluetzner
pushed a commit
to iternity-dotcom/minio
that referenced
this pull request
Jun 8, 2022
We do not reliably know the length of compressed data, including headers. Request until the end-of-stream. Results will still be properly truncated. Fixes minio#13441 (cherry picked from commit 76239fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We do not reliably know the length of compressed data, including headers.
Request until the end-of-stream. Results will still be properly truncated.
Fixes #13441
zipindexupgrade fixes CRC errors being written (not returned to users though).How to test this PR?
Mint test: minio/minio-go#1570
Types of changes