Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom request headers #1961

Closed
wants to merge 1 commit into from

Conversation

olljanat
Copy link

@olljanat olljanat commented May 15, 2024

First step to implement minio/minio#19698 by allowing client to set User-Agent and X-Forwarded-For headers for all requests.

Needed by minio/minio#19744

@harshavardhana
Copy link
Member

harshavardhana commented May 15, 2024

This is non-standard and non-idiomatic. There are no boundary checks on sanitized headers etc.

This can even conflict and cause signature issues if not carefully used.

@olljanat
Copy link
Author

Those are standard HTTP headers and MinIO rely on them in it's code. Blocking ability to use them here does not provide any extra security because any customized client can use what ever values they want on those.

That why there is this warning

The aws:Referer, aws:SourceIp, and aws.UserAgent keys may be easily spoofed and therefore pose a potential security risk

in https://min.io/docs/minio/linux/administration/identity-access-management/policy-based-access-control.html#id6

However, if would be way to get those to MinIO backend when SFTP is used then it is possible to block those connection from certain IPs and example completely from SFTP clients to some buckets with policies like I listed in minio/minio#19698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants