Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remote target is permanently marked offline by mistake #1684

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

garenchan
Copy link
Contributor

Issue

The steps to reproduce the issue are as follows:

  1. Stop the remote target.
  2. Upload a file to local target and we will see in the log that remote target is offline.
  3. Wait a while to ensure that a health check is performed.
  4. Start the remote target and verify that it is accessible.
  5. No matter how long we wait, the local target always considers the remote target to be offline.

Reason

When the remote target or network is down, the health check timer will not be reset. So even if the remote target or network recovers later, it will be permanently marked offline by mistake.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @garenchan

@garenchan
Copy link
Contributor Author

@vadmeste, why don't we run unit tests to find these issues?

@harshavardhana
Copy link
Member

@vadmeste, why don't we run unit tests to find these issues?

@garenchan feel free to write one.

@harshavardhana harshavardhana merged commit a80fee3 into minio:master Aug 1, 2022
@garenchan garenchan deleted the ck-dev branch August 2, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants