Report non-XML formated error details #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids hiding further error context in the case when it is coming from a layer, which is not necessarily using the S3 XML error format.
simonswine
changed the title
klauspost
requested changes
Nov 16, 2021
|
@simonswine Seems like some formatting is required. Otherwise LGTM. |
Co-authored-by: Klaus Post <klauspost@gmail.com>
simonswine
force-pushed
the
20211116_better-s3-error-handling
branch
from
124fb51
to
36d740d
Compare
should be good now |
klauspost
approved these changes
Nov 16, 2021
harshavardhana
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids hiding further error context in the case when it is coming from a layer, which is not necessarily using the S3 XML error format.
Note: The separate commit also ensures an unrelated test case is called