Update minio-go to forward S3 error messages, which are not in XML #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
changed the title
bboreham
reviewed
Nov 15, 2021
| @@ -98,6 +101,14 @@ const ( | |||
| reportIssue = "Please report this issue at https://github.com/minio/minio-go/issues." | |||
| ) | |||
|
|
|||
| func xmlDecodeAndBody(bodyReader io.Reader, v interface{}) ([]byte, error) { | |||
| body, err := ioutil.ReadAll(bodyReader) | |||
There was a problem hiding this comment.
Consider using a limited reader here, otherwise there is danger of crashing if the far-end has included 26GB of detail.
|
👍 I think it's a good idea fixing it (and yes, we have to do it in the upstream client). |
|
I have raised this PR: minio/minio-go#1585 |
simonswine
force-pushed
the
20211115_better-s3-error-handling
branch
from
8930d8f
to
886aa8d
Compare
simonswine
changed the title
This ensure that S3 API errors are returned in detail even though if they are not XML formatted.
simonswine
force-pushed
the
20211115_better-s3-error-handling
branch
from
886aa8d
to
1f8f255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a problem I encountered a couple of times with minio s3 client. It hides no XML parseable error detail.
This PR is mainly to agree on the best way to deal with this and then I would try to upstream it to the minio client.