Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NewArnFromString when parsing user-provided ARN string #4378

Merged
merged 1 commit into from Dec 1, 2022
Merged

Use NewArnFromString when parsing user-provided ARN string #4378

merged 1 commit into from Dec 1, 2022

Conversation

vgarvardt
Copy link
Contributor

Description

Slightly simplify code by reusing library functionality introduced at minio/minio-go#1721

Motivation and Context

Slightly less code to achieve the same functionality.

How to test this PR?

No functional changes, existing tests should pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit 9fb024f into minio:master Dec 1, 2022
@vgarvardt vgarvardt deleted the patch/simplify-arn-parsing branch December 1, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@klauspost klauspost klauspost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vgarvardt @harshavardhana @klauspost