Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing headers support #4297

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

klauspost
Copy link
Contributor

@klauspost klauspost commented Oct 12, 2022

Description

Add trailing headers to requests when specified in config.

Requires minio/minio-go#1705

How to test this PR?

Modify config:

		"mys3": {
			"url": "https://s3.amazonaws.com",
			"accessKey": "AKIA3WNQJCXE3JVMGFPN",
			"secretKey": xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
			"api": "s3v4",
			"path": "auto",
			"trailingHeaders":true
		},

Types of changes

  • New feature (non-breaking change which adds functionality)

Add trailing headers to requests when specified in config.

Requires minio/minio-go#1705
@klauspost klauspost marked this pull request as ready for review October 19, 2022 13:19
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

cmd/config-v10.go Show resolved Hide resolved
cmd/client-s3.go Show resolved Hide resolved
@harshavardhana
Copy link
Member

Will get this reviewed by @abperiasamy if we are okay to make changes to config.json with new fields. Sorry for the delay.

# Conflicts:
#	go.mod
#	go.sum
@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 18, 2023
@harshavardhana
Copy link
Member

Still valid needs discussion.

@stale stale bot removed the stale label Mar 18, 2023
@klauspost klauspost changed the title Add trailing headers support Add trailing headers checksum support May 3, 2023
@klauspost klauspost changed the title Add trailing headers checksum support Add trailing headers support May 3, 2023
@harshavardhana
Copy link
Member

Will discuss this with @abperiasamy next week and get this merged.

@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants