Add support of per bucket scanner report #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
klauspost
reviewed
Sep 19, 2023
metrics.go
Outdated
Comment on lines
236
to
238
| CurrentCycle uint64 `json:"current_cycle"` // Deprecated Sep 2023 | ||
| CurrentStarted time.Time `json:"current_started"` // Deprecated Sep 2023 | ||
| CyclesCompletedAt []time.Time `json:"cycle_complete_times"` // Deprecated Sep 2023 |
There was a problem hiding this comment.
Why is this deprecated?
I didn't see this; well, since a new bucket will be scanned when there is an available disk; there is no concept of scan cycle anymore; let's discuss this futher if you want
klauspost
reviewed
Sep 19, 2023
metrics.go
Outdated
| if s.CollectedAt.Before(other.CollectedAt) { | ||
| // Use latest timestamp | ||
| s.CollectedAt = other.CollectedAt | ||
| } | ||
|
|
||
| if s.BucketsScanInfo.OngoingBuckets < other.BucketsScanInfo.OngoingBuckets { | ||
| s.BucketsScanInfo.OngoingBuckets = other.BucketsScanInfo.OngoingBuckets |
There was a problem hiding this comment.
So this is only being sent from the (master) server controlling the scan?
harshavardhana
force-pushed
the
scanner-v2
branch
from
46c6477
to
31972d6
Compare
harshavardhana
force-pushed
the
main
branch
2 times, most recently
from
c96b346
to
112c599
Compare
Each bucket will be scanned individually, this commit will deprecate old cycle scan metrics since there is no concept of a full cycle in the upcoming per bucket scan change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each bucket will be scanned individually, this commit will deprecate
old cycle scan metrics since there is no concept of a full cycle in the
upcoming per bucket scan change.