Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file for development environment #50

Merged
merged 1 commit into from Jan 5, 2023
Merged

Conversation

jk-gan
Copy link
Contributor

@jk-gan jk-gan commented Jan 4, 2023

Summary

Previously the development environment and production environment share the same config file path, this cause a lot of confusion even for me. This PR adds a config file path for the development environment (~/.config/wukong/dev/config.toml). Running wukong without prod features, which only happens during development, will use the development environment config file.

Ticket:

What's Changed

Added

  • add config file for development environment

Changed

@jk-gan jk-gan requested review from onimsha and Fadhil January 4, 2023 05:08
@jk-gan jk-gan self-assigned this Jan 4, 2023
@jk-gan jk-gan added the enhancement New feature or request label Jan 4, 2023
@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jk-gan, onimsha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onimsha onimsha merged commit 27593e7 into main Jan 5, 2023
@sauron-droid sauron-droid deleted the feat/dev-config-path branch January 5, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L
Development

Successfully merging this pull request may close these issues.

None yet

3 participants