Skip to content

Commit

Permalink
Issue checkstyle#6207: Add xpath regression test for UnusedImports
Browse files Browse the repository at this point in the history
  • Loading branch information
mincong-h authored and Mincong HUANG committed Aug 13, 2019
1 parent d2cf01e commit fc00575
Show file tree
Hide file tree
Showing 3 changed files with 95 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
////////////////////////////////////////////////////////////////////////////////
// checkstyle: Checks Java source code for adherence to a set of rules.
// Copyright (C) 2001-2019 the original author or authors.
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
////////////////////////////////////////////////////////////////////////////////

package org.checkstyle.suppressionxpathfilter;

import java.io.File;
import java.util.Collections;
import java.util.List;

import org.junit.Test;

import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck;

public class XpathRegressionUnusedImportsTest extends AbstractXpathTestSupport {

private final String checkName = UnusedImportsCheck.class.getSimpleName();

@Override
protected String getCheckName() {
return checkName;
}

@Test
public void testOne() throws Exception {
final File fileToProcess =
new File(getPath("SuppressionXpathRegressionUnusedImportsOne.java"));

final DefaultConfiguration moduleConfig =
createModuleConfig(UnusedImportsCheck.class);

final String[] expectedViolation = {
"3:8: " + getCheckMessage(UnusedImportsCheck.class,
UnusedImportsCheck.MSG_KEY, "java.util.List"),
};

final List<String> expectedXpathQueries = Collections.singletonList(
"/IMPORT/DOT[./IDENT[@text='List']]/DOT/IDENT[@text='java']");

runVerifications(moduleConfig, fileToProcess, expectedViolation,
expectedXpathQueries);
}

@Test
public void testTwo() throws Exception {
final File fileToProcess =
new File(getPath("SuppressionXpathRegressionUnusedImportsTwo.java"));

final DefaultConfiguration moduleConfig =
createModuleConfig(UnusedImportsCheck.class);

final String[] expectedViolation = {
"3:15: " + getCheckMessage(UnusedImportsCheck.class,
UnusedImportsCheck.MSG_KEY, "java.util.Map.Entry"),
};

final List<String> expectedXpathQueries = Collections.singletonList(
"/STATIC_IMPORT/DOT[./IDENT[@text='Entry']]/DOT[./IDENT[@text='Map']]"
+ "/DOT/IDENT[@text='java']");

runVerifications(moduleConfig, fileToProcess, expectedViolation,
expectedXpathQueries);
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package org.checkstyle.suppressionxpathfilter.unusedimports;

import java.util.List; // warn

public class SuppressionXpathRegressionUnusedImportsOne {

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package org.checkstyle.suppressionxpathfilter.unusedimports;

import static java.util.Map.Entry; // warn

public class SuppressionXpathRegressionUnusedImportsTwo {

}

0 comments on commit fc00575

Please sign in to comment.