Implement partial UA client hints support for gmail #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a few days ago, Gmail now checks (for unknown reasons) for
navigator.userAgentData. If it isn't found, it redirects to the basic HTML version.Client hints currently doesn't work in Electron: electron/electron#30201. So this PR adds a (somewhat ridiculous) workaround of creating a fake
userAgentDataobject that mostly conforms to the one Chrome provides. With that, the standard version of Gmail seems to load again.Separately, signing in to Gmail is broken, see #868. You can workaround that by setting your user-agent to Firefox in preferences, but then you'll have to switch back to the standard user-agent after signing in before trying this fix.
I wish Google would stop trying to block non-official Chromium browsers...