Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4]channel manager's goroutine run order #33121

Merged
merged 3 commits into from
May 21, 2024

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented May 17, 2024

See also: #33117
pr: #33118

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 17, 2024
Copy link
Contributor

mergify bot commented May 17, 2024

@XuanYang-cn Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/bug Issues or changes related a bug label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (2f260cd) to head (4158173).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33121      +/-   ##
==========================================
- Coverage   82.14%   81.79%   -0.35%     
==========================================
  Files        1005     1005              
  Lines      128037   128038       +1     
==========================================
- Hits       105170   104728     -442     
- Misses      18899    19322     +423     
- Partials     3968     3988      +20     
Files Coverage Δ
internal/datanode/channel_manager.go 92.65% <100.00%> (-1.38%) ⬇️

... and 42 files with indirect coverage changes

Copy link
Contributor

mergify bot commented May 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 20, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 20, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

See also: milvus-io#33117

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b2f7d7b into milvus-io:2.4 May 21, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the c/2.4/fix/cm-ut branch May 21, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants