Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor serializing int type to buffer #33068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented May 15, 2024

Signed-off-by: luzhang <luzhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 15, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 15, 2024
Copy link
Contributor

mergify bot commented May 15, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 15, 2024

/run-cpu-e2e

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 82.21%. Comparing base (40e5c0b) to head (f3ce918).
Report is 129 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33068      +/-   ##
==========================================
+ Coverage   82.06%   82.21%   +0.15%     
==========================================
  Files        1005      996       -9     
  Lines      127648   128395     +747     
==========================================
+ Hits       104748   105556     +808     
+ Misses      18923    18869      -54     
+ Partials     3977     3970       -7     
Files Coverage Δ
internal/core/src/index/ScalarIndexSort.cpp 74.26% <100.00%> (-0.17%) ⬇️
internal/core/src/storage/Util.cpp 80.68% <100.00%> (-0.57%) ⬇️
internal/core/src/storage/BinlogReader.h 91.66% <87.50%> (-8.34%) ⬇️
internal/core/src/common/Utils.h 90.26% <71.42%> (+1.96%) ⬆️
internal/core/src/storage/Event.cpp 80.97% <77.50%> (-0.43%) ⬇️

... and 238 files with indirect coverage changes

Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants