Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify componet ip #27161

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

smellthemoon
Copy link
Contributor

/kind feature
#26538

@sre-ci-robot sre-ci-robot added the kind/feature Issues related to feature request from users label Sep 18, 2023
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 18, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #27161 (eaeb718) into master (0459a66) will decrease coverage by 0.09%.
Report is 2 commits behind head on master.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27161      +/-   ##
==========================================
- Coverage   82.58%   82.49%   -0.09%     
==========================================
  Files         786      796      +10     
  Lines      112349   112589     +240     
==========================================
+ Hits        92782    92885     +103     
- Misses      16362    16492     +130     
- Partials     3205     3212       +7     
Files Changed Coverage Δ
internal/datanode/data_node.go 74.08% <ø> (ø)
internal/datanode/flow_graph_delete_node.go 89.34% <0.00%> (-0.74%) ⬇️
internal/datanode/flow_graph_insert_buffer_node.go 77.39% <0.00%> (-1.24%) ⬇️
internal/util/flowgraph/node.go 80.80% <16.66%> (+5.27%) ⬆️
internal/datanode/services.go 82.45% <66.66%> (-0.25%) ⬇️
internal/datanode/flow_graph_time_tick_node.go 91.30% <97.05%> (+0.51%) ⬆️
internal/datanode/channel_meta.go 94.28% <100.00%> (+0.21%) ⬆️
internal/datanode/flush_manager.go 91.14% <100.00%> (ø)
pkg/util/funcutil/func.go 87.77% <100.00%> (+0.27%) ⬆️
pkg/util/paramtable/grpc_param.go 80.95% <100.00%> (+0.43%) ⬆️

... and 170 files with indirect coverage changes

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Sep 20, 2023
@sre-ci-robot sre-ci-robot merged commit d1f6825 into milvus-io:master Sep 20, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants