Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade confluent kafka go version #18293

Merged
merged 1 commit into from Jul 22, 2022

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jul 15, 2022

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor area/compilation area/dependency Pull requests that update a dependency file labels Jul 15, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 15, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jul 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

@jaime0815 E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@jiaoew1991
Copy link
Contributor

No need to set tags for build is perfect👍

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2022

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #18293 (2b471da) into master (73aef14) will increase coverage by 0.12%.
The diff coverage is 88.97%.

❗ Current head 2b471da differs from pull request most recent head 009f995. Consider uploading reports for the commit 009f995 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18293      +/-   ##
==========================================
+ Coverage   81.81%   81.93%   +0.12%     
==========================================
  Files         477      480       +3     
  Lines       75532    76564    +1032     
==========================================
+ Hits        61794    62732     +938     
- Misses      11018    11056      +38     
- Partials     2720     2776      +56     
Impacted Files Coverage Δ
internal/querycoord/impl.go 90.20% <86.20%> (-0.76%) ⬇️
internal/querycoord/task.go 77.65% <87.03%> (+0.78%) ⬆️
internal/querycoord/task_scheduler.go 79.54% <100.00%> (+1.99%) ⬆️
internal/distributed/connection_manager.go 74.00% <0.00%> (-6.86%) ⬇️
internal/datacoord/util.go 77.08% <0.00%> (-6.60%) ⬇️
internal/querycoord/group_balance.go 67.30% <0.00%> (-5.25%) ⬇️
internal/datacoord/garbage_collector.go 90.09% <0.00%> (-5.15%) ⬇️
internal/querycoord/global_meta_broker.go 70.04% <0.00%> (-4.51%) ⬇️
internal/querycoord/channel_unsubscribe.go 80.17% <0.00%> (-2.44%) ⬇️
internal/util/flowgraph/node.go 73.60% <0.00%> (-2.41%) ⬇️
... and 75 more

@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2022

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-checks

@mergify mergify bot removed the ci-passed label Jul 21, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2022

@jaime0815, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Jul 21, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2022

@jaime0815 E2e jenkins job failed, comment /run-checks can trigger the job again.

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaime0815, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3ec147a into milvus-io:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants