Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated warning on Mac OS #18151

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

jiaoew1991
Copy link
Contributor

Signed-off-by: Enwei Jiao enwei.jiao@zilliz.com
/kind improvement

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor area/dependency Pull requests that update a dependency file labels Jul 7, 2022
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 7, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jul 7, 2022
@jiaoew1991
Copy link
Contributor Author

they fixed the compile warning in v1.2.1 99designs/keyring#107

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Jul 7, 2022
@jiaoew1991
Copy link
Contributor Author

rerun ut

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #18151 (31bd7f6) into master (6df47c7) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18151      +/-   ##
==========================================
+ Coverage   81.72%   81.81%   +0.09%     
==========================================
  Files         472      475       +3     
  Lines       75261    75574     +313     
==========================================
+ Hits        61507    61832     +325     
- Misses      11014    11021       +7     
+ Partials     2740     2721      -19     
Impacted Files Coverage Δ
internal/indexnode/task_state.go 50.00% <0.00%> (-50.00%) ⬇️
internal/util/mock/grpc_indexnode_client.go 83.33% <0.00%> (-16.67%) ⬇️
internal/indexcoord/priority_queue.go 75.24% <0.00%> (-10.90%) ⬇️
internal/datanode/data_sync_service.go 70.73% <0.00%> (-4.27%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-4.24%) ⬇️
internal/indexnode/indexnode_mock.go 80.43% <0.00%> (-2.48%) ⬇️
internal/indexcoord/util.go 97.67% <0.00%> (-2.33%) ⬇️
internal/indexnode/indexnode.go 86.59% <0.00%> (-2.01%) ⬇️
internal/datanode/flow_graph_dd_node.go 89.86% <0.00%> (-1.80%) ⬇️
internal/distributed/indexnode/client/client.go 81.25% <0.00%> (-1.31%) ⬇️
... and 29 more

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5eb35f2 into milvus-io:master Jul 8, 2022
@jiaoew1991 jiaoew1991 deleted the fix-warning-macos branch July 20, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants