fix: Maximum call stack size exceeded (sveltejs#4694)

src/compiler/compile/css/Stylesheet.ts

@@ -1,3 +1,25 @@
+// push-array.ts start
+// TODO move pushArray to npm module
+//export{}
+//declare global {
+//  interface Array<T>  {
+//    pushArray(...otherList: any[]): number;
+//  }
+//}
+(Array.prototype as any).pushArray = function pushArray(...otherList: any[]) {
+  let c = 0; // count pushed elements
+  for (let a = 0; a < otherList.length; a++) {
+    const other = otherList[a];
+    for (let i = 0; i < other.length; i++) {
+      this.push(other[i]);
+      c++;
+    }
+  }
+  return c;
+};
+// push-array.ts end
+
+
 import MagicString from 'magic-string';
 import { walk } from 'estree-walker';
 import Selector from './Selector';
@@ -351,7 +373,7 @@ export default class Stylesheet {
 							const at_rule_declarations = node.block.children
 								.filter(node => node.type === 'Declaration')
 								.map(node => new Declaration(node));
-							atrule.declarations.push(...at_rule_declarations);
+							atrule.declarations.pushArray(at_rule_declarations);
 						}
 
 						current_atrule = atrule;

src/compiler/compile/nodes/shared/map_children.ts

@@ -1,3 +1,25 @@
+// push-array.ts start
+// TODO move pushArray to npm module
+//export{}
+//declare global {
+//  interface Array<T>  {
+//    pushArray(...otherList: any[]): number;
+//  }
+//}
+(Array.prototype as any).pushArray = function pushArray(...otherList: any[]) {
+  let c = 0; // count pushed elements
+  for (let a = 0; a < otherList.length; a++) {
+    const other = otherList[a];
+    for (let i = 0; i < other.length; i++) {
+      this.push(other[i]);
+      c++;
+    }
+  }
+  return c;
+};
+// push-array.ts end
+
+
 import AwaitBlock from '../AwaitBlock';
 import Body from '../Body';
 import Comment from '../Comment';
@@ -58,7 +80,7 @@ export default function map_children(component, parent, scope, children: Templat
 		if (use_ignores) component.pop_ignores(), ignores = [];
 
 		if (node.type === 'Comment' && node.ignores.length) {
-			ignores.push(...node.ignores);
+			ignores.pushArray(node.ignores);
 		}
 
 		if (last) last.next = node;

src/compiler/compile/render_dom/wrappers/Element/index.ts

@@ -1,3 +1,25 @@
+// push-array.ts start
+// TODO move pushArray to npm module
+//export{}
+//declare global {
+//  interface Array<T>  {
+//    pushArray(...otherList: any[]): number;
+//  }
+//}
+(Array.prototype as any).pushArray = function pushArray(...otherList: any[]) {
+  let c = 0; // count pushed elements
+  for (let a = 0; a < otherList.length; a++) {
+    const other = otherList[a];
+    for (let i = 0; i < other.length; i++) {
+      this.push(other[i]);
+      c++;
+    }
+  }
+  return c;
+};
+// push-array.ts end
+
+
 import Renderer from '../../Renderer';
 import Element from '../../../nodes/Element';
 import Wrapper from '../shared/Wrapper';
@@ -596,7 +618,7 @@ export default class ElementWrapper extends Wrapper {
 		this.attributes.forEach((attribute) => {
 			if (attribute.node.name === 'class') {
 				const dependencies = attribute.node.get_dependencies();
-				this.class_dependencies.push(...dependencies);
+				this.class_dependencies.pushArray(dependencies);
 			}
 		});
 

src/compiler/compile/render_dom/wrappers/IfBlock.ts

@@ -1,3 +1,25 @@
+// push-array.ts start
+// TODO move pushArray to npm module
+//export{}
+//declare global {
+//  interface Array<T>  {
+//    pushArray(...otherList: any[]): number;
+//  }
+//}
+(Array.prototype as any).pushArray = function pushArray(...otherList: any[]) {
+  let c = 0; // count pushed elements
+  for (let a = 0; a < otherList.length; a++) {
+    const other = otherList[a];
+    for (let i = 0; i < other.length; i++) {
+      this.push(other[i]);
+      c++;
+    }
+  }
+  return c;
+};
+// push-array.ts end
+
+
 import Wrapper from './shared/Wrapper';
 import Renderer from '../Renderer';
 import Block from '../Block';
@@ -166,7 +188,7 @@ export default class IfBlockWrapper extends Wrapper {
 			block.has_outro_method = has_outros;
 		});
 
-		renderer.blocks.push(...blocks);
+		renderer.blocks.pushArray(blocks);
 	}
 
 	render(

src/compiler/preprocess/decode_sourcemap.ts

@@ -1,3 +1,25 @@
+// push-array.ts start
+// TODO move pushArray to npm module
+//export{}
+//declare global {
+//  interface Array<T>  {
+//    pushArray(...otherList: any[]): number;
+//  }
+//}
+(Array.prototype as any).pushArray = function pushArray(...otherList: any[]) {
+  let c = 0; // count pushed elements
+  for (let a = 0; a < otherList.length; a++) {
+    const other = otherList[a];
+    for (let i = 0; i < other.length; i++) {
+      this.push(other[i]);
+      c++;
+    }
+  }
+  return c;
+};
+// push-array.ts end
+
+
 import { decode as decode_mappings } from 'sourcemap-codec';
 import { Processed } from './types';
 
@@ -50,7 +72,7 @@ function decoded_sourcemap_from_generator(generator: any) {
 		result_segment = result_line[result_line.length - 1];
 
 		if (mapping.source != null) {
-			result_segment.push(...[
+			result_segment.pushArray([
 				source_idx[mapping.source],
 				mapping.originalLine - 1, // line is one-based
 				mapping.originalColumn

src/compiler/preprocess/index.ts

@@ -1,3 +1,25 @@
+// push-array.ts start
+// TODO move pushArray to npm module
+//export{}
+//declare global {
+//  interface Array<T>  {
+//    pushArray(...otherList: any[]): number;
+//  }
+//}
+(Array.prototype as any).pushArray = function pushArray(...otherList: any[]) {
+  let c = 0; // count pushed elements
+  for (let a = 0; a < otherList.length; a++) {
+    const other = otherList[a];
+    for (let i = 0; i < other.length; i++) {
+      this.push(other[i]);
+      c++;
+    }
+  }
+  return c;
+};
+// push-array.ts end
+
+
 import { RawSourceMap, DecodedSourceMap } from '@ampproject/remapping/dist/types/types';
 import { getLocator } from 'locate-character';
 import { MappedCode, SourceLocation, parse_attached_sourcemap, sourcemap_add_offset, combine_sourcemaps } from '../utils/mapped_code';
@@ -48,7 +70,7 @@ class PreprocessResult implements Source {
 		}
 
 		if (dependencies) {
-			this.dependencies.push(...dependencies);
+			this.dependencies.pushArray(dependencies);
 		}
 	}
 
@@ -165,7 +187,7 @@ async function process_tag(
 		});
 
 		if (!processed) return no_change();
-		if (processed.dependencies) dependencies.push(...processed.dependencies);
+		if (processed.dependencies) dependencies.pushArray(processed.dependencies);
 		if (!processed.map && processed.code === content) return no_change();
 
 		return processed_tag_to_code(processed, tag_name, attributes, slice_source(content, tag_offset, source));