Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix syntax for setup.cfg #77

Merged
merged 1 commit into from Sep 18, 2021
Merged

Conversation

llimllib
Copy link
Contributor

If you follow the instructions in the README for adding pytest-socket to your setup.cfg, you get:

Failed: [pytest] section in setup.cfg files is no longer supported, changeto [tool:pytest] instead.

This PR adds the correct syntax for setup.cfg, and also links to the pytest documentation for the different configuration locations.

If you follow the instructions in the README for adding pytest-socket to your setup.cfg, you get:

```
Failed: [pytest] section in setup.cfg files is no longer supported, changeto [tool:pytest] instead.
```

This PR adds the correct syntax for setup.cfg, and also links to the pytest documentation for the different configuration locations.
@codeclimate
Copy link

codeclimate bot commented Sep 15, 2021

Code Climate has analyzed commit 97cddff and detected 0 issues on this pull request.

View more on Code Climate.

@llimllib
Copy link
Contributor Author

Possibly https://docs.pytest.org/en/6.2.x/plugins.html?highlight=conftest#requiring-loading-plugins-in-a-test-module-or-conftest-file would be a better link for conftest.py? I didn't find a really high-quality documentation of that file.

@miketheman miketheman added the documentation Improvements or additions to documentation label Sep 18, 2021
Copy link
Owner

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Agreed, I haven't found the best link for conftest, so this ought to do for now.

@miketheman miketheman merged commit 47ed91c into miketheman:main Sep 18, 2021
@llimllib llimllib deleted the patch-1 branch September 18, 2021 13:39
@miketheman miketheman added this to the 0.50.0 milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants