Handle family passed as keyword argument

[emontnemery]

Handle family passed as keyword argument to socket constructor

[emontnemery]

@miketheman can this get merged, or are there any concerns?

Instead of this:

def __new__(cls, *args, **kwargs):

We could perhaps do:

def __new__(cls, family=AF_INET, type=SOCK_STREAM, proto=0, fileno=None)

[miketheman]

Hi @emontnemery !

I'm lacking context as to why this is an improvement on the existing behavior, as well as any tests to validate the change works as intended.

[emontnemery]

The current code throws if the socket is created with its parameters passed as keywords instead of as positional arguments, this PR fixes that by handling both cases.

I've added testcases where socket.socket() is called with keyword arguments or no arguments.

[emontnemery]

Maybe this should be changed to def __new__(cls, family=AF_INET, type=SOCK_STREAM, proto=0, fileno=None) instead, then we can simply check family, instead of handling both positional and keyword arguments cases.

[miketheman]

Interesting - maybe this should be more compatible with the defaults of the underlying class? https://github.com/python/cpython/blob/59435eea08d30796174552c0ca03c59b41adf8a5/Lib/socket.py#L220

[emontnemery]

OK, updated to mimic the CPython implementation, i.e.:

def __new__(cls, family=-1, type=-1, proto=-1, fileno=None)

[codeclimate]

Code Climate has analyzed commit fc0ba71 and detected 0 issues on this pull request.

View more on Code Climate.

[miketheman]

Thanks for working through this!