Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve warnings #1597

Closed
wants to merge 1 commit into from
Closed

Solve warnings #1597

wants to merge 1 commit into from

Conversation

eval
Copy link
Collaborator

@eval eval commented Jan 3, 2024

@eval eval requested a review from sebbASF January 3, 2024 13:52
@sebbASF
Copy link
Collaborator

sebbASF commented Jan 3, 2024

Given that these mostly come from generated files, it might be better to just ignore them as suggested here:

https://dev.to/qortex/ruby-suppress-those-warnings-you-can-t-do-anything-about-6ie

@eval
Copy link
Collaborator Author

eval commented Jan 3, 2024

While an easy option (for us), I think it's better in this case to not ship a transitive dependency for downstream users. Something the most popular gems using warning-gem also don't seem to do (ie it's a development dependency).

@eval eval force-pushed the issue/remove-warnings-master branch from b709cbb to fefb854 Compare January 3, 2024 16:12
@skipkayhil
Copy link
Contributor

skipkayhil commented Jan 8, 2024

This looks like an incomplete version of #1551. All of those parser files are generated by rake ragel, so modifying them by hand is not a good idea in my opinion.

Copy link

@dorianmariecom dorianmariecom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@eval
Copy link
Collaborator Author

eval commented Jun 3, 2024

All of those parser files are generated by rake ragel, so modifying them by hand is not a good idea in my opinion.

@skipkayhil you're right, closing this one.

@eval eval closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings when parsing
4 participants