Handle parsing of LF-only body with separate parts #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conversion of body to CRLF does not help here because body is not ascii_only so does not get converted. Instead to search for CR?LF (optional CR) in which case conversion to CRLF is unnecessary.
mikel
added
Ready to Merge
|
As the 2.8 branch doesn't have all the specs running automatically, waiting for #1437 to be green before merging this. |
|
Seems to be all OK |
gbp
added a commit
to mysociety/alaveteli
that referenced
this pull request
Aug 2, 2023
Always start with the unmasked attachment body when applying the masks and censor rules. We're going to make changes which mean `FoiAttachment#body` will return masked body, fetch this with `default_body` could result in attachment with old or superseded censor rules still applied. Needed to force HTML attachment into CRLF line endings due to an issue with the mail gem which results in a different hexdigest after rebuilding the raw emails from a file on disk in the specs. Once mikel/mail#1512 is merged we can revert the FoiAttachment factory change.
gbp
added a commit
to mysociety/alaveteli
that referenced
this pull request
Aug 3, 2023
Always start with the unmasked attachment body when applying the masks and censor rules. We're going to make changes which mean `FoiAttachment#body` will return masked body, fetch this with `default_body` could result in attachment with old or superseded censor rules still applied. Needed to force HTML attachment into CRLF line endings due to an issue with the mail gem which results in a different hexdigest after rebuilding the raw emails from a file on disk in the specs. Once mikel/mail#1512 is merged we can revert the FoiAttachment factory change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #1319
Conversion of body to CRLF does not help here because body is not ascii_only so does not get converted. Instead to search for CR?LF (optional CR) in which case conversion to CRLF is unnecessary.