Treat sideEffects array as inclusion list

- Fixes rollup#226
mikeharder · Jun 20, 2019 · 91107fe · 91107fe
1 parent cdb7448
commit 91107fe
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -146,7 +146,7 @@ export default function nodeResolve ( options = {} ) {
 			packageInfo.hasModuleSideEffects = () => packageSideEffects;
 		} else if (Array.isArray(packageSideEffects)) {
 			const filter = createFilter(packageSideEffects, null, {resolve: pkgRoot});
-			packageInfo.hasModuleSideEffects = id => !filter(id);
+			packageInfo.hasModuleSideEffects = id => filter(id);
 		}
 
 		packageInfoCache.set(pkgPath, packageInfo);

diff --git a/test/node_modules/side-effects-array/package.json b/test/node_modules/side-effects-array/package.json
diff --git a/test/test.js b/test/test.js
@@ -890,8 +890,9 @@ describe( 'rollup-plugin-node-resolve', function () {
 				'true-dep1',
 				'true-dep2',
 				'true-index',
-				'array-dep2',
-				'array-dep4',
+				'array-dep1',
+				'array-dep3',
+				'array-dep5',
 				'true-index'
 			]);
 			delete global.sideEffects;