Replace gulp-util with alternatives #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demurgos
suggested changes
Dec 30, 2017
package.json
Outdated
| "through2": "^2.0.3" | ||
| "plugin-error": "^0.1.2", | ||
| "through2": "^2.0.3", | ||
| "vinyl": "^2.1.0" |
There was a problem hiding this comment.
vinyl should be in the devDependencies, it is only used for the tests.
Please update it: it is important to avoid unnecessary dependencies.
There was a problem hiding this comment.
Thanks! I tweaked it. 46efdc6
|
Thanks for the PR, I had some issues with the tests and did not have time to look into this yesterday. @mikaelbr Could we have this merged? |
demurgos
approved these changes
Dec 30, 2017
|
🎉 thanks! |
|
@mikaelbr Thank you too! |
|
@mikaelbr Can this be published to npm? ^_^ thanks! |
|
Indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello gulp-notify maintainers.
Following gulpjs/gulp-util#143, I dropped dependency on gulp-util.
closes #123
Thanks!