Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Endpoints #114

Merged
merged 13 commits into from
Jan 20, 2021
Merged

Various Endpoints #114

merged 13 commits into from
Jan 20, 2021

Conversation

skorfmann
Copy link
Collaborator

Thanks for your initial effort, this got me going quickly so I added a few endpoints. It's still work in progress, though.

A few things I noted / questions:

  • camel-casing the response doesn't seem to work for me
  • Had to downgrade axios due to type errors
  • what's the best way to reference it locally? (e.g. yarn link) (Had to add main / types entry to package.json to make it work)

@mijailr
Copy link
Owner

mijailr commented Dec 1, 2020

Looks great, lets see your issues, please give me more details, I'm happy to help. Also try to rebase your branch with main I just fixed the issue with github actions @skorfmann

@skorfmann
Copy link
Collaborator Author

The "issues" in codeclimate are a bit weird

@skorfmann
Copy link
Collaborator Author

  • what's the best way to reference it locally? (e.g. yarn link) (Had to add main / types entry to package.json to make it work)

I thought semantic-release is doing some magic there. However, looks like these entries are really missing.

@mijailr
Copy link
Owner

mijailr commented Dec 2, 2020

The "issues" in codeclimate are a bit weird

Fixed

  • what's the best way to reference it locally? (e.g. yarn link) (Had to add main / types entry to package.json to make it work)

I thought semantic-release is doing some magic there. However, looks like these entries are really missing.

You mean to link the terraform client as a path on another project? I never tried that before, maybe the packaging is needed. Do you know a way to fix that?

Does it works if you do yarn build and make the yarn link within the pkg folder?

@skorfmann
Copy link
Collaborator Author

The "issues" in codeclimate are a bit weird

Fixed

👍

You mean to link the terraform client as a path on another project? I never tried that before, maybe the packaging is needed. Do you know a way to fix that?

I mean even for the published npm package (I did publish a temporary package in npm) . And yes, for the local workflows as well.

@mijailr
Copy link
Owner

mijailr commented Dec 4, 2020

Maybe pika is not the best option for the packaging in this case or we need to use pika in another way. Let me know when we can merge this.

@skorfmann skorfmann marked this pull request as ready for review January 19, 2021 23:00
@skorfmann
Copy link
Collaborator Author

@mijailr please have a look - that's the state what we're using at the moment. However, happy to expand on it.

Copy link
Owner

@mijailr mijailr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 LGTM!

@mijailr
Copy link
Owner

mijailr commented Jan 20, 2021

Many thanks @skorfmann

@mijailr mijailr merged commit 58ef0b8 into mijailr:main Jan 20, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Released label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants