Fix for Node Path instance not being sent to onEachFile and onEachDirectory callbacks #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory callbacks The README says: "The callback function takes the directory item (has path, name, size, and extension) and an instance of [node path](https://nodejs.org/api/path.html) and an instance of [node FS.stats](https://nodejs.org/api/fs.html#fs_class_fs_stats)." However, the callbacks are not sent the Node Path instance but instead are sent the `path` variable. Changing from `path` to `PATH` fixes it to work as described in the README.
|
@photonstorm thanks for the PR! Going over this I was actually thinking - why do we even need the path module passed as an argument to the callback function? I went through git history and it was added like that from a contribution, but really - do we need it? Seems to complicate things. I'm guessing if one needs the node path module they can simply require it in their code, no? (If you agree, perhaps we could turn around this PR into actually removing that arg altogether.) Thanks! |
|
I agree, I don't think it's needed at all. If you need path or fs stats you can just import it yourself. Happy to close this PR and do a new one if you just want to remove it entirely. |
|
I think it would make sense, yep. Thanks a lot!
…On Tue, May 4, 2021 at 6:48 PM Richard Davey ***@***.***> wrote:
I agree, I don't think it's needed at all. If you need path or fs stats
you can just import it yourself.
Happy to close this PR and do a new one if you just want to remove it
entirely.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE5AN7ESTW4SSNRU6WIJCDTMAJLFANCNFSM43UW4AOQ>
.
--
Mihnea Dobrescu-Balaur
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README says: "The callback function takes the directory item (has path, name, size, and extension) and an instance of node path and an instance of node FS.stats."
However, the callbacks are not sent the Node Path instance but instead are sent the
pathvariable.Changing from
pathtoPATHfixes it to work as described in the README.