Always pop allow_unsafe_werkzeug
from kwargs
#1877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a (non-production) Flask-SocketIO app in an environment without a real shell requires to pass
allow_unsafe_werkzeug=True
intosocketio.run()
. However, adding this option results in an error when run with a real shell (e.g. for development purposes), as the option is passed toapp.run()
which then complains about it:There is a simple workaround for now (
sys.stdin = False
), but I'd rather fix this here by always popping the option off kwargs.