Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SocketIO.run() add additional reloader specific parameters. #1556

Closed
wants to merge 3 commits into from
Closed

SocketIO.run() add additional reloader specific parameters. #1556

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d5f654
SocketIO.run() new reloader specific params
indietyp May 20, 2021
f27d666
fix typo
indietyp May 20, 2021
f73aabe
fix W291 trailing whitespace
indietyp May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 13 additions & 2 deletions flask_socketio/__init__.py
View file
Open in desktop
Expand Up @@ -529,6 +529,11 @@ def run(self, app, host=None, port=None, **kwargs):
to disable it.
:param extra_files: A list of additional files that the Flask
reloader should watch. Defaults to ``None``
:param exclude_patterns: A list of patterns (matched by fnmatch)
the Flask reloader should exclude.
Defaults to ``None``
:param reloader_type: The reloader Flask should use when
reloading is enabled. Detauls to ``auto``
:param log_output: If ``True``, the server logs all incoming
connections. If ``False`` logging is disabled.
Defaults to ``True`` in debug mode, ``False``
Expand All @@ -554,6 +559,8 @@ def run(self, app, host=None, port=None, **kwargs):
log_output = kwargs.pop('log_output', debug)
use_reloader = kwargs.pop('use_reloader', debug)
extra_files = kwargs.pop('extra_files', None)
exclude_patterns = kwargs.pop('exclude_patterns', None)
reloader_type = kwargs.pop('reloader_type', 'auto')

app.debug = debug
if app.debug and self.server.eio.async_mode != 'threading':
Expand Down Expand Up @@ -616,7 +623,9 @@ def run_server():
log_output=log_output, **kwargs)

if use_reloader:
run_with_reloader(run_server, extra_files=extra_files)
run_with_reloader(run_server, extra_files=extra_files,
exclude_patterns=exclude_patterns,
reloader_type=reloader_type)
else:
run_server()
elif self.server.eio.async_mode == 'gevent':
Expand Down Expand Up @@ -650,7 +659,9 @@ def run_server():
def run_server():
self.wsgi_server.serve_forever()

run_with_reloader(run_server, extra_files=extra_files)
run_with_reloader(run_server, extra_files=extra_files,
exclude_patterns=exclude_patterns,
reloader_type=reloader_type)
else:
self.wsgi_server.serve_forever()

Expand Down