Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update go-github to v60 #66

Closed
wants to merge 4 commits into from

Conversation

quike
Copy link
Contributor

@quike quike commented Mar 18, 2024

https://github.com/google/go-github/releases/tag/v60.0.0
CHANGELOG

Extra:

  • Add makefile defs with common operations.
  • Update endpoints based on current version.
  • Add .editorconfig for IDE expected code style.
  • Add vendors to gitignore to avoid mistakes pushing deps.

@quike quike marked this pull request as ready for review March 18, 2024 19:51
@quike
Copy link
Contributor Author

quike commented Mar 18, 2024

@migueleliasweb any chance you could take a look? also, shall we enable github actions for pull request testing? I saw you have a PR #1 but never got merged. I do have a primary approach here: https://github.com/quike/go-github-mock/actions but tell me what you would like and we can build it progressively. At least I am trying to put so far build/test/lint so pr's can be verified and later add automatic semver or anything else.

@migueleliasweb
Copy link
Owner

@migueleliasweb any chance you could take a look? also, shall we enable github actions for pull request testing? I saw you have a PR #1 but never got merged. I do have a primary approach here: https://github.com/quike/go-github-mock/actions but tell me what you would like and we can build it progressively. At least I am trying to put so far build/test/lint so pr's can be verified and later add automatic semver or anything else.

That would be great to have :). I'll have a look at your implementation and we can create a separate PR to work on that.

@migueleliasweb
Copy link
Owner

I'll have a look later tonight about the changes. Thanks for the contributions :).

@quike
Copy link
Contributor Author

quike commented Mar 22, 2024

@migueleliasweb any chance to take a look to this one? thanks

@quike
Copy link
Contributor Author

quike commented Mar 29, 2024

I'll have a look later tonight about the changes. Thanks for the contributions :).

Any chance to do it? Thanks

@migueleliasweb
Copy link
Owner

New release with v61 of go-github: https://github.com/migueleliasweb/go-github-mock/releases/tag/v0.1.

Can we close this one for now?

@quike quike closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants