New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mutex to FIFOResponseHandler #29
Add mutex to FIFOResponseHandler #29
Conversation
Fix possible data race in FIFOResponseHandler.ServeHTTP by adding a mutex.
Hi @mheck136 , thanks for the PR! Could you also add the mutex to the |
Hi @migueleliasweb, I don't think that there is any risk of a data race for |
It's all good, let me double check a couple things and I will be right back with you. |
Hi @mheck136 , yeah we probably won't need the mutex in the paginated handler for now. Can you just merge the two Then I can merge and create a new release :) |
@migueleliasweb, I'm not sure that's a good idea. I would keep the |
@migueleliasweb , how do you want to proceed with this PR? |
@migueleliasweb , I still think it would be best to keep the code as it is. When |
Hi @mheck136 , sorry for the delay. Life has been pretty busy lately. Let's merge this 👍 |
Fix possible data race in FIFOResponseHandler.ServeHTTP by adding a
mutex.
Addresses #28