Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint v8 #759

Merged
merged 2 commits into from Apr 21, 2022
Merged

feat: support ESLint v8 #759

merged 2 commits into from Apr 21, 2022

Conversation

theoludwig
Copy link
Contributor

@theoludwig theoludwig commented Feb 1, 2022

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

Support ESLint v8.

Which issue (if any) does this pull request address?

Fixes #728

Is there anything you'd like reviewers to focus on?

Even if #727, @mightyiam, do you still want to review or we can merge/release with another standard maintainer approval?

@theoludwig theoludwig self-assigned this Feb 1, 2022
@theoludwig theoludwig force-pushed the feat/support-eslint-v8 branch 2 times, most recently from 9dfdeab to f39e0d6 Compare February 1, 2022 19:56
@jefbarn
Copy link

jefbarn commented Feb 1, 2022

Possible to publish a pre-release version of this for testing? (because the config file is typescript, can't just use the branch directly in eslint config)

@theoludwig
Copy link
Contributor Author

@jefbarn Yes, we can certainly do a prerelease before a stable release.
I don't have the right to publish on npm, we need to wait an approval from another standard maintainer.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
Copy link

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave it to @mightyiam to decide on this one, as he is the one driving this part of standard

@flippidippi
Copy link

Any updates on this? We are waiting for this to be released so we can upgrade to eslint 8.

@theoludwig
Copy link
Contributor Author

Any updates on this? We are waiting for this to be released so we can upgrade to eslint 8.

@flippidippi It is blocked by: standard/eslint-config-standard#208

@jefbarn
Copy link

jefbarn commented Mar 25, 2022

For people wanting to start using this, my solution was:

  1. Fork the repo
  2. Switch to this branch git branch feat/eslint-support-v8
  3. Compile the code npm run compile
  4. Remove '/lib' from .gitignore
  5. Commit and push the /lib folder to your new repo
  6. Use the project.json github syntax:
    "eslint-config-standard-with-typescript": "jefbarn/eslint-config-standard-with-typescript#feat/support-eslint-v8"

Though this solution is not great if we need to merge in changes from upstream.

@theoludwig
Copy link
Contributor Author

@mightyiam This should now be ready! 😄
Do you mind reviewing this PR again and if everything is fine, releasing a new major version of eslint-config-standard-with-typescript, thanks!

@mightyiam
Copy link
Owner

I'll do my best.

@gutenye
Copy link

gutenye commented May 4, 2022

Any updates on the release? eslint-config-standard is released

mightyiam added a commit that referenced this pull request Jun 6, 2022
closes #806

BREAKING CHANGE: several peerDep bumps including eslint@^8.0.1 (was
omitted in #759)
rostislav-simonik added a commit that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8
6 participants