#1365: Add test to sanitize IPv6 address in case it's not in brackets #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miekg
added a commit
that referenced
this pull request
Apr 15, 2022
|
This has been separately fixed by #1368. |
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
Small fix in the examples to properly work with v6 addresses. Closes: miekg#1365 miekg#1367 Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing issue #1365
Note: not using To4() methods to avoid string/ip conversion, but feel free to fail the request if you'd rather have this.