Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up NextLabel and PrevLabel #1039

Merged
merged 7 commits into from Dec 4, 2019
Merged

Speed up NextLabel and PrevLabel #1039

merged 7 commits into from Dec 4, 2019

Commits on Nov 26, 2019

  1. change NextLabel and PrevLabel to be faster 

    This reduces readability, but they are in the hot path of coredns.
    @jpicht
    jpicht committed Nov 26, 2019
    Copy the full SHA
    0df2149 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. @redyeti pointed out, that my implementation disregarded triple backs… 

    …lashes
    @jpicht
    jpicht committed Nov 27, 2019
    Copy the full SHA
    3cef566 View commit details
    Browse the repository at this point in the history

  2. add synthetic benchmark-tests for PrevLabel and NextLabel

    @jpicht
    jpicht committed Nov 27, 2019
    Copy the full SHA
    588b785 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2019

  1. rename ii -> j

    @jpicht
    jpicht committed Nov 30, 2019
    Copy the full SHA
    57a9af5 View commit details
    Browse the repository at this point in the history

  2. invert compare

    @jpicht
    jpicht committed Nov 30, 2019
    Copy the full SHA
    0c48829 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. PrevLabel: add empty string check + test case

    @jpicht
    jpicht committed Dec 2, 2019
    Copy the full SHA
    adb64c4 View commit details
    Browse the repository at this point in the history

  2. NextLabel: fix and add testcase for NextLabel("", offset>0)

    @jpicht
    jpicht committed Dec 2, 2019
    Copy the full SHA
    0f96db1 View commit details
    Browse the repository at this point in the history