New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock execjs to 2.7.0 #2568
Lock execjs to 2.7.0 #2568
Conversation
It still dont work in |
@henrique-ft It looks like you need to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should modify
s.add_dependency('execjs', ['~> 2']) |
Gemfile
Outdated
@@ -41,4 +41,7 @@ gem 'simplecov', '~> 0.21', require: false | |||
gem 'middleman-cli', path: 'middleman-cli' | |||
gem 'middleman-core', path: 'middleman-core' | |||
|
|||
# Locked in 2.7.0 until https://github.com/rails/execjs/issues/99 be solved (still dont work in 2.8.1) | |||
gem 'execjs', '2.7.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @henrique-ft 👋🏼
This is not necessary anymore ✂️, as it was already defined in the gemspec now
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR solves the problem of #2564
Many people having this problem did the same, it is a
execjs
issue: rails/execjs#99