Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump autoprefixer-rails #39

Closed
wants to merge 4 commits into from
Closed

Conversation

bunnymatic
Copy link

Problem

autoprefixer-rails v 9.x was reporting deprecation warnings everytime
you did a build or serve.

DEPRECATION WARNING: autoprefixer-rails was deprected. Migration guide:
https://github.com/ai/autoprefixer-rails/wiki/Deprecated (called from load at /Users/jon/.rbenv/versions/2.6.5/bin/middleman:23)

Some futher investigation makes me think it's not in fact deprecated but
has picked up some new owners and is still in development.

Solution

Bump to the new version (10.0.1) to suppress the error message.

I tested this locally by building a current middleman project and the
css that came out was identical to the previous version. Also your
tests still pass.

Problem
-------

`autoprefixer-rails` v 9.x was reporting deprecation warnings everytime
you did a build or serve.

```
DEPRECATION WARNING: autoprefixer-rails was deprected. Migration guide:
https://github.com/ai/autoprefixer-rails/wiki/Deprecated (called from load at /Users/jon/.rbenv/versions/2.6.5/bin/middleman:23)
```

Some futher investigation makes me think it's not in fact deprecated but
has picked up some new owners and is still in development.

Solution
---------

Bump to the new version (10.0.1) to suppress the error message.

I tested this locally by building a current middleman project and the
css that came out was identical to the previous version.  Also your
tests still pass.
@bunnymatic
Copy link
Author

It looks like the new version of autoprefixer wants a more modern version of Node - more modern than what's on Travis. Will you support that bump as well?

@bunnymatic
Copy link
Author

Wait... nevermind. This does not work because of a typo fix in autoprefixer-rails that hasn't been merged in. ai/autoprefixer-rails@0fc26b5 (ai/autoprefixer-rails#192). I might try against their master branch and see how it goes.

@bunnymatic
Copy link
Author

I'll leave this one until autoprefixer get's that fix in.

@bunnymatic bunnymatic closed this Nov 2, 2020
@bunnymatic bunnymatic reopened this Nov 5, 2020
@bunnymatic
Copy link
Author

The issue I was seeing is fixed on ai/autoprefixer-rails (ai/autoprefixer-rails#194). I don't see the (incorrect) deprecation warning and the site works with autoprefixing.

@tdreyno
Copy link
Member

tdreyno commented Nov 6, 2020

I think adding the following to the travis config will help those errors:

before_install:
  - nvm install 10

@tdreyno
Copy link
Member

tdreyno commented Nov 12, 2020

Merged this manually here: f9efe59

Will get a release out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants