Fixed errors due to rubocop 0.81 update #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of Rubocop requires new cops to be explicitly set to true or false.  I have set all the new ones to true in these changes. Many students are having trouble due to [stickler](https://stickler-ci.com/docs#ruby) having updated their Rubocop version to 0.81. I propose 1 or 2 or both changes: Setting all cops to "DisabledByDefault: true", and/or setting the highlighted new cops above to true or false (I have made them true in this file)
|
This is a problem that we encountered in our project with @ikraamg |
|
I saw that a pull request for this fix was already requested. Apologies for the duplicate. I will close this for now. |
|
The fix has been merged: #63. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of Rubocop requires new cops to be explicitly set to true or false.
Many students are having trouble due to stickler having updated their Rubocop version to 0.81.
I propose one or both changes: Setting all cops to "DisabledByDefault: true", and/or setting the highlighted new cops above to true or false (I have made them true in this file)