Handling failed post delete service calls #79

maleekha · 2020-10-13T19:09:07Z

Summary of the changes

Adding a synced-state in each store which gets updated only when post/delete calls succeed, and is also shown to the users on the preview page/student view page.
In case any post/delete call fails, a sticky message is shown at the top of the page with a pertinent error message based on the service error type. An error is also shown in case the user state is not synced with (even when all the calls succeeded).
A spinner on the top of the page to indicate that some service calls are in progress.
Warning inside modal when the user tries to publish the assignment and (I) some service calls are in progress, or (II) the assignment is not synced (due to some error or otherwise).
Failure message in case publishStatusChange call fails.

…entLinks 2. StudentView page & preview page will show only AssignmentLinks synced with the server and not those links which were not successfully added to the assignment. 3. Publishing the assignment will show appropriate message if data is not synced

2. removed extra comments

…ges; warnings inside modal

… updates consistent with other stores.

…y in git

…oring

error handling for POST calls in Assignment.store

This reverts commit f70068d.

…ror messages; code refactoring

…side.

… on contentUids. At a time for a particular contentUid, only one service call can be in progress, others will have to wait.i

… using the toggleItemSelection

…ithub.com/microsoft/Learn-LTI into handling-failed-POST-DELETE-service-calls

… items in error state --TODO: use them to store-level error show/hide messages.

making errorMsg to be at store level

adding AssignmentUpdateFailureMessage bar to student view as well

removing unnecessary commented lines

changed learn-content to Microsoft learn content

updated isSynced logic for LinkStore and included serviceCall in progress to determine if a satore has an error or not

tweaked how the assignment gets updated

…ll revert this later.

…-all-content button

leestott · 2021-03-15T12:56:29Z

Just waiting/scheduling time with Engineering for regression testing to ensure this does not break any aspects.

No Impact to exiting deployment, so users can deploy the services without this change,

nehalilani and others added 23 commits October 9, 2020 01:50

learncontent- error handling for post and delete calls

c9e11b1

using the promise object properly now

54a8c0e

Error handling for publishStatusChange call

b00be7a

error handling for AssignmentLinks - fixes

969ddd9

improved publish button action

4661667

removed console.log statement, extra spaces

dbe145a

Changing serviceCallInProgress from boolean to number

5574421

1. error handling for Assignment APIs

f5ece3b

2. removed extra comments

Error handling for get and post calls; added appropraiate error messa…

2f8f3ce

…ges; warnings inside modal

Assignment store synced state on publish; warning text

cd55741

Error message for publish status change when the user is unauthorized

e2930dd

Updating warning text styles; making assignment link store on-publish…

b9e974c

… updates consistent with other stores.

Merge branch 'main' into handling-failed-POST-DELETE-service-calls

e95f637

Updating LearnStore from main

c7dfca9

Updating MicrosoftLearnStore -- fixing diff from main to show properl…

f2f3be8

…y in git

Assignment updating spinner; renamed failure message bar; code refact…

b730715

…oring

error handling for GET call in Links and Learn Content stores

65cbe8a

error handling for POST calls in Assignment.store

Refactoring learn store

f70068d

Revert "Refactoring learn store"

ef66b22

This reverts commit f70068d.

Modifying student-view to show synced assignment content; updating er…

56d1ffe

…ror messages; code refactoring

Updating student view description and deadline

d0b1ca6

removing error handling for getCatalog -- TODO: To be done on server …

26adb49

…side.

maleekha requested a review from adbindal October 13, 2020 19:09

maleekha added 6 commits October 14, 2020 23:00

Updating Learnstore error handling- including waiting mechanism based…

b2f8f10

… on contentUids. At a time for a particular contentUid, only one service call can be in progress, others will have to wait.i

build fix

dd73a01

Updating Microsoft Learn Content-item toggle logic to use observables

3145cd8

Code-refactoring; added call-status

776ad42

Updated LearnStore to handle error case of clear all call

9b61ddc

Refactoring LearnStore; removing removeItem-action, as it can be done…

993e0c2

… using the toggleItemSelection

maleekha and others added 28 commits October 19, 2020 16:22

Fix for unnecessary links, learn-content, me calls on assignment update

8251fdf

Merge branch 'handling-failed-POST-DELETE-service-calls' of https://g…

3f2808e

…ithub.com/microsoft/Learn-LTI into handling-failed-POST-DELETE-service-calls

minor syntax uodates

3606311

Soft fade-in fade-out for assignmentUpdateFailureMessageBar

478d79e

Updating links and learn-store to have computed variables storing the…

fc1f826

… items in error state --TODO: use them to store-level error show/hide messages.

Update AssignmentUpdateFailureMessageBar.tsx

9ff5066

making errorMsg to be at store level

Update MainLayout.tsx

76c3b08

adding AssignmentUpdateFailureMessage bar to student view as well

Update AssignmentUpdateFailureMessageBar.tsx

fbf4c52

removing unnecessary commented lines

updating AssignmentFailMessageBar to display store-specific messages.

6e464fb

minor updates to make code look cleaner

97ddea1

Update AssignmentUpdateFailureMessageBar.tsx

5d64de4

changed learn-content to Microsoft learn content

Merge branch 'main' into handling-failed-POST-DELETE-service-calls

71790b3

Updated store-specific message in the assignmentUpdateFailureMessageBar

4931a47

Fixing issues in Assignment and Links store

53617d5

Update AssignmentLinks.store.ts

6c8e6ed

LinksStore update

6207f21

updated isSynced logic for LinkStore and included serviceCall in progress to determine if a satore has an error or not

Fixing learn store clear-all issue

9d47ea2

Removing unnecessary comments

2f6b74f

Update Assignment.store.ts

abba9d8

Update Assignment.store.ts

643b26c

tweaked how the assignment gets updated

Update Assignment.store.ts

e7ede1a

Update Assignment.store.ts

cad7743

Update Assignment.store.ts

f3ce995

updated error messages

b16c568

Update Assignment.store.ts

17cbbfc

Update Assignment.store.ts

736dc4a

Temporarily hardcoding the linkid and contentuid in service calls. Wi…

e1a119f

…ll revert this later.

Fixed issues in learn-store; modified the disable condition for clear…

601fc77

…-all-content button

leestott requested a review from nehalilani March 4, 2021 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handling failed post delete service calls #79

Handling failed post delete service calls #79

maleekha commented Oct 13, 2020 •

edited by adbindal

leestott commented Mar 15, 2021

Handling failed post delete service calls #79

Are you sure you want to change the base?

Handling failed post delete service calls #79

Conversation

maleekha commented Oct 13, 2020 • edited by adbindal

Summary of the changes

leestott commented Mar 15, 2021

maleekha commented Oct 13, 2020 •

edited by adbindal