Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HSTRING to conform to Rust's aliasing rules #2057

Merged
merged 1 commit into from Sep 22, 2022
Merged

Fix HSTRING to conform to Rust's aliasing rules #2057

merged 1 commit into from Sep 22, 2022

Commits on Sep 22, 2022

  1. Fix subtle UB 

    Pointers derived from `&mut` references must still uphold the uniqueness guarantee. Therefore we should be using a shared reference when duplicating `HSTRING`s.
    @ChrisDenton
    ChrisDenton committed Sep 22, 2022
    Copy the full SHA
    ae13153 View commit details
    Browse the repository at this point in the history