Remove unused bindgen options
#1994
Conversation
| pub min_enum: bool, | ||
| pub min_inherit: bool, | ||
| pub min_xaml: bool, | ||
| pub windows_extern: bool, |
There was a problem hiding this comment.
So windows_extern is critical for anyone that wants to build on top of this crate and expose features dependent on upstream features (e.g. windows-app-rs). I don't think we have any active crates using this at this very moment, but I'd vote for keeping this as it has minimal impacts to bindgen and removes a significant crate adoption roadblock, especially for those looking to transform additional Microsoft SDKs.
There was a problem hiding this comment.
I'm just not sure how common that is or whether that was something you'll only hit when you're doing some crazy like Xaml or WinAppSDK. The DIA example doesn't appear to need that.
There was a problem hiding this comment.
Fair. We can re-add easy enough when a new case presents itself.
These options were used by the internal bindings as well as Xaml code generation and are no longer needed.